![]() Using the Git-Flow branching model you can create new branches for both of these features and send two requests. The reason for this is that if you change X and Y but send a pull request for both at the same time, we might really want X but disagree with Y, meaning we cannot merge the request. That does not mean only one commit, but one change - however many commits it took. One thing at a time: A pull request should only contain one change. If you have multiple changes to submit, please place all changes into their own branch on your fork. For this reason all commits need to be made to "develop" and any sent to "master" will be closed automatically. The "master" branch will always contain the latest stable version and is kept clean so a "hotfix" (e.g: an emergency security patch) can be applied to master to create a new version, without worrying about other features holding it up. Where the next planned version will be developed. BranchingĬodeIgniter uses the Git-Flow branching model which requires all pull requests to be sent to the "develop" branch. If PHP 5.3 (and above) functions or features are used then CompatibilityĬodeIgniter recommends PHP 5.4 or newer to be used, but it should beĬompatible with PHP 5.2.4 so all code supplied must stick to this The change-log must also be updated for every change. New classes, methods, parameters, changing default values, etc are all things that will require a change to documentation. If you change anything that requires a change to documentation then you will need to add it. This makes certain that all code is the same format as the existing code and means it will be as readable as possible. PHP StyleĪll code must meet the Style Guide, which isĮssentially the Allman indent style, underscores and readable operators. ![]() This might sound a bit tough, but it is requiredįor us to maintain quality of the code-base. To pass these guidelines it will be declined and you will need to re-submit Guidelinesīefore we look into how, here are the guidelines. This will require you to use the version control system called Git. Reporting issues is helpful but an even better approach is to send a Pull Request, which is done by "Forking" the main repository and committing to your own copy. Is it something really obvious that you can fix yourself?.The issue has already been fixed (check the develop branch, or look for closed Issues). ![]() If you find a bug or documentation error in CodeIgniter then please check a few things first: Issues are a quick way to point out a bug. These contributions are made in the form of Issues or Pull Requests on the CodeIgniter repository on GitHub. CodeIgniter is a community driven project and accepts contributions of code and documentation from the community. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |